Patch for space seperated bword links.

[zhangjinsong]

Bug report is here: http://goldendict.org/forum/viewtopic.php?f=6&t=882

After a lot of googling, I found it difficult to replace my problematic Babylon dictionaries to their dsl counterparts because of my complete ignorance of Russian language.
Then I wrote this patch.
Here it is, see attachment, it works fine.

[ikm]

Could you elaborate how this patch works exactly?

[zhangjinsong]

OK, if the following contains any errors, let me know please.

Qtwebkit (at least 4.6.X) can't handle any URI with its host part containing space character or "%20" or something similar, but if those offending characters are in the path part, everything goes OK.
In GD, the host part of "bword" scheme is completely useless, its host part and path part are altogether sent to "gdlookup" scheme URI as its query item.

Obviously, in GD, "bword" scheme should be non-hierarchical, like "mailto", as explained by RFC3986, with the whole "location identifier" as its path part.

So, there is a simple solution to that problem: make "bword" the same as "mailto", that is, disable its host part, as the patch does.

Er, it seems I forgot to delete the code handling the host part (now, it's an empty string) of "bword" link in ArticleView::openLink() function, the new patch is in the attachment of this post.

[ikm]

Fair enough. However, please do the bword replacements in bgl.cc:673, after replaceCharsetEntities, not in bgl_babylon, which shouldn't be doing GD-specific transforms. This way you also wouldn't need to bump up the ParserVersion.

[zhangjinsong]

OK, the new patch is here.

[ikm]

Great work! Patch applied.

[zhangjinsong]

Hi, ikm:
It seems stardict also use "bword://" in its internal cross reference, so stardict.cc need to be patched too.
The patch is here, see attachment.

[ikm]

Applied, thanks.